Treat source files as UTF-8 to avoid encoding errors #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid errors like this: gems/simplecov-0.5.4/lib/simplecov/source_file.rb:158:in `block in process_skipped_lines!': invalid byte sequence in US-ASCII (ArgumentError) A fixture file is included which contains a degree symbol. The line containing the symbol currently causes the above exception.
|
I experienced this same error, and this patch fixed it. Spec looks good, I think it should be merged. |
colszowka
added a commit
that referenced
this pull request
Jan 27, 2012
Treat source files as UTF-8 to avoid encoding errors
|
Great, thanks a lot! |
Closed
|
New gem release 0.6.0 rolls out in a couple minutes |
rlqualls
pushed a commit
to rlqualls/sugarcane
that referenced
this pull request
Feb 1, 2014
I can't get a failing test case, though it is failing on one of our projects and is the same bug and fix as that in simplecov: simplecov-ruby/simplecov#103
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid errors like this:
gems/simplecov-0.5.4/lib/simplecov/source_file.rb:158:in `block in process_skipped_lines!': invalid byte sequence in US-ASCII (ArgumentError)
A fixture file is included which contains a degree symbol. The line containing the symbol currently causes the above exception.